-
Notifications
You must be signed in to change notification settings - Fork 732
Reverse Dependency: trace-dispatcher no longer depends on trace-forward #6268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f6edd80
to
7602ed5
Compare
f2fd6f8
to
84b40c3
Compare
19b0584
to
bcf52e7
Compare
mgmeier
requested changes
Jul 22, 2025
Could you please add the following to the PR:
EDIT: Don't forget the changes from #6283 which you wanted to subsume here as well. |
23ae172
to
92918ce
Compare
Fixes for tests and imports Cabal versions
92918ce
to
48c92ee
Compare
mgmeier
approved these changes
Jul 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decouples
trace-dispatcher
fromtrace-forward
, thereby removing its dependency on network-related libraries and Cardano-specific modules.It bumps packages to the following versions:
trace-dispatcher-2.10.0
trace-forward-2.3.0
cardano-tracer-0.3.4
Motivation
Previously,
trace-dispatcher
depended ontrace-forward
, which in turn pulled inouroboros-network
and a substantial portion of the Cardano ecosystem. This entanglement made it cumbersome to usetrace-dispatcher
in simpler or non-Cardano settings.What Changed
trace-forward
trace-dispatcher
remains focused on its core responsibility: dispatching traces, not networkingBenefits
trace-dispatcher
in new projects or different ecosystems