Skip to content

Conversation

jutaro
Copy link
Contributor

@jutaro jutaro commented Jul 1, 2025

This PR decouples trace-dispatcher from trace-forward, thereby removing its dependency on network-related libraries and Cardano-specific modules.

It bumps packages to the following versions:

  • trace-dispatcher-2.10.0
  • trace-forward-2.3.0
  • cardano-tracer-0.3.4

Motivation

Previously, trace-dispatcher depended on trace-forward, which in turn pulled in ouroboros-network and a substantial portion of the Cardano ecosystem. This entanglement made it cumbersome to use trace-dispatcher in simpler or non-Cardano settings.

What Changed

  • Removed the direct dependency on trace-forward
  • Refactored or restructured any modules or types that required it
  • Ensured that trace-dispatcher remains focused on its core responsibility: dispatching traces, not networking

Benefits

  • Lighter dependency footprint
  • Easier reuse of trace-dispatcher in new projects or different ecosystems
  • Paves the way for more modular and maintainable tracing infrastructure

@jutaro jutaro requested a review from mgmeier July 1, 2025 17:17
@jutaro jutaro force-pushed the jutaro/trace-dispatcher--forwarding branch 3 times, most recently from f6edd80 to 7602ed5 Compare July 6, 2025 13:05
@jutaro jutaro marked this pull request as ready for review July 6, 2025 18:58
@jutaro jutaro requested review from a team as code owners July 6, 2025 18:58
@jutaro jutaro marked this pull request as draft July 7, 2025 10:23
@jutaro jutaro force-pushed the jutaro/trace-dispatcher--forwarding branch 2 times, most recently from f2fd6f8 to 84b40c3 Compare July 16, 2025 08:54
@jutaro jutaro marked this pull request as ready for review July 16, 2025 08:58
@jutaro jutaro force-pushed the jutaro/trace-dispatcher--forwarding branch 4 times, most recently from 19b0584 to bcf52e7 Compare July 22, 2025 07:56
@mgmeier
Copy link
Contributor

mgmeier commented Jul 22, 2025

Could you please add the following to the PR:

  1. short changelog entries for trace-* packages
  2. please bump cardano-tracer version to 0.3.4

EDIT: Don't forget the changes from #6283 which you wanted to subsume here as well.

@jutaro jutaro force-pushed the jutaro/trace-dispatcher--forwarding branch from 23ae172 to 92918ce Compare July 23, 2025 07:20
@mgmeier mgmeier force-pushed the jutaro/trace-dispatcher--forwarding branch from 92918ce to 48c92ee Compare July 23, 2025 07:44
Copy link
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@mgmeier mgmeier added this pull request to the merge queue Jul 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 23, 2025
@mgmeier mgmeier added this pull request to the merge queue Jul 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 23, 2025
@mgmeier mgmeier added this pull request to the merge queue Jul 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 23, 2025
@johnalotoski johnalotoski added this pull request to the merge queue Jul 23, 2025
Merged via the queue into master with commit f11e0f3 Jul 23, 2025
24 checks passed
@johnalotoski johnalotoski deleted the jutaro/trace-dispatcher--forwarding branch July 23, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants